Add mode-dependent vim cursor to radian/session.py #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't believe that some one takes it that far. Thank you for the contribution. I haven't reviewed it but I would like to make sure that backward compatibility is guaranteed. |
|
@randy3k, how can backward compatibility be best guaranteed? GitHub Actions workflow to build different versions? |
mskar
force-pushed
the
cursor
branch
2 times, most recently
from
8e1638c
to
ca2cfab
Compare
increase timeoutlen to facilitate use of vim combos like daW, diB, ct), etc. add settings options to adjust [t]timeoutlen and disable modal_cursor
randy3k
force-pushed
the
master
branch
2 times, most recently
from
b161529
to
ac0e9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request demonstrates the vim mode-dependent cursor mentioned (by @petobens) in #153 and requested (by me) in #220.
The cursor shape is
I put the cursor code into the
apply_settings()function insession.py, but I doubt I picked the right spot on my first try馃槃This PR only effects vi mode.
Currently, this feature is enabled by default, but it can be disabled using by adding
to
.radian_profile.To install a version of radian with the modal cursor, run the line below.
python -m pip install git+https://github.com/mskar/radian.git@cursor