Add EC_Scalar and EC_AffinePoint types #4042
Open
+1,234
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
randombit
force-pushed
the
jack/new-ec-types
branch
2 times, most recently
from
03b58cd
to
bae2ce8
Compare
randombit
force-pushed
the
jack/new-ec-types
branch
4 times, most recently
from
a70db6d
to
b09a762
Compare
randombit
force-pushed
the
jack/new-ec-types
branch
6 times, most recently
from
4db015d
to
b594b6b
Compare
randombit
force-pushed
the
jack/new-ec-types
branch
2 times, most recently
from
2e230e4
to
d5fa5d9
Compare
These have a much more restrictive interface as compared to our existing EC_Point and BigInt
randombit
force-pushed
the
jack/new-ec-types
branch
from
d5fa5d9
to
94c81d6
Compare
randombit
commented
Jun 3, 2024
|
|
||
| Mul2Table(const EC_AffinePoint& h); | ||
|
|
||
| std::optional<EC_AffinePoint> mul2(const EC_Scalar& x, const EC_Scalar& y) const; |
There was a problem hiding this comment.
Document the conditions this returns none
src/lib/pubkey/ec_group/ec_scalar.h
Outdated
|
|
||
| static std::vector<uint8_t> serialize_pair(const EC_Scalar& r, const EC_Scalar& s); | ||
|
|
||
| std::vector<uint8_t> serialize() const; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other side of #3979 where we push the interface that's exposed to the rest of the library to a non-BigInt oriented model.
#4027