Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.29] Bump k8s dependencies to support k8s v1.29 #3575

Merged
merged 4 commits into from
May 21, 2024

Conversation

krunalhinguu
Copy link
Collaborator

@krunalhinguu krunalhinguu commented May 2, 2024

Updates

  • Bump dependecies to 0.29.3
  • Bump go version to 1.22 (as norman is already on 1.22)
  • Removed code related to podsecuritypolicy
  • Bump golang version to 1.22 in Dockerfile.dapper
  • Bump golangci-lint version to v1.57.2

TODO

  • KDM url in codegen.go needs to be updated to actual branch.
  • norman tag needs to be updated once PR is merged.

Related

@enrico9034
Copy link

The branch tested with this cluster.yml file

nodes:
- address: 10.50.20.112
  port: "22"
  internal_address: 172.168.0.132
  role:
  - controlplane
  - worker
  - etcd
  hostname_override: 10.50.20.112
  user: cloud-user
  docker_socket: /var/run/docker.sock
  ssh_key_path: ~/.ssh/id_rsa
services:
  kube-api:
    service_cluster_ip_range: 10.43.0.0/16
  kube-controller:
    cluster_cidr: 10.42.0.0/16
    service_cluster_ip_range: 10.43.0.0/16
  kubelet:
    cluster_domain: rancher.10.50.20.112.nip.io
    cluster_dns_server: 10.43.0.10
network:
  plugin: flannel
authentication:
  strategy: x509
ssh_key_path: ~/.ssh/id_rsa
authorization:
  mode: rbac
kubernetes_version: "v1.29.3-rancher1-1"

And this is the result

NAME          STATUS   ROLES                      AGE     VERSION
10.50.20.112   Ready    controlplane,etcd,worker   2m36s   v1.29.3

if c.Authorization.Mode != services.RBACAuthorizationMode {
return errors.New("PodSecurityPolicy can't be enabled with RBAC support disabled")
}
if parsedRangeAtLeast125(parsedVersion) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krunalhinguu maybe we should keep this error so users can see it's removed instead of silently ignoring

@kinarashah kinarashah requested a review from a team May 16, 2024 21:07
@kinarashah
Copy link
Member

Other changes LGTM

@enrico9034
Copy link

LGTM

@chiukapoor chiukapoor merged commit 25d3846 into rancher:release/v1.6 May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants