-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.29] Bump k8s dependencies to support k8s v1.29 #3575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
krunalhinguu
force-pushed
the
rancher-1.29
branch
2 times, most recently
from
May 3, 2024 08:43
eac2cd1
to
718a73a
Compare
krunalhinguu
force-pushed
the
rancher-1.29
branch
from
May 15, 2024 03:42
718a73a
to
77b5525
Compare
The branch tested with this cluster.yml file
And this is the result
|
enrico9034
approved these changes
May 16, 2024
kinarashah
reviewed
May 16, 2024
if c.Authorization.Mode != services.RBACAuthorizationMode { | ||
return errors.New("PodSecurityPolicy can't be enabled with RBAC support disabled") | ||
} | ||
if parsedRangeAtLeast125(parsedVersion) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krunalhinguu maybe we should keep this error so users can see it's removed instead of silently ignoring
Other changes LGTM |
krunalhinguu
force-pushed
the
rancher-1.29
branch
from
May 17, 2024 05:00
77b5525
to
bc12cd0
Compare
krunalhinguu
force-pushed
the
rancher-1.29
branch
from
May 17, 2024 05:52
e5a8080
to
f7e0e53
Compare
krunalhinguu
force-pushed
the
rancher-1.29
branch
from
May 17, 2024 17:04
f7e0e53
to
cc43e0d
Compare
enrico9034
approved these changes
May 20, 2024
LGTM |
kinarashah
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
0.29.3
1.22
(as norman is already on 1.22)podsecuritypolicy
1.22
inDockerfile.dapper
golangci-lint
version tov1.57.2
TODO
codegen.go
needs to be updated to actual branch.Related