Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom certificate life/expiration. #3217

Open
wants to merge 2 commits into
base: release/v1.4
Choose a base branch
from

Conversation

TheSp1der
Copy link

This pull request adds support to RKE to allow the configuration of certificate lifetime/expiration to support typical corporate requirements for shorter certificate expiration.

This change acknowledges that the default certificate lifetime for cluster certificates is ~10 years and makes no change to that default. Instead it adds support for a cluster.yml configuration option called certificate_lifetime. The certificate_lifetime option accepts an integer being a number of days from the current date for which certificates will be valid. This logic is respected during both the creation of a new cluster or during certificate rotation. This modification does not make any changes to the CA's created by RKE.

@TheSp1der
Copy link
Author

This pull request is still valid.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@TheSp1der
Copy link
Author

This pull request is still valid.

@superseb superseb self-assigned this Aug 7, 2023
@superseb superseb added this to the v1.4.11 milestone Sep 27, 2023
@superseb superseb modified the milestones: v1.4.11, v1.4.12 Nov 16, 2023
@superseb superseb removed their assignment Dec 14, 2023
@jiaqiluo jiaqiluo removed this from the v1.4.12 milestone Mar 27, 2024
Copy link
Contributor

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants