-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.9] Add new agent TLS chart value & validation jsonSchema #45522
Open
mallardduck
wants to merge
6
commits into
rancher:release/v2.9
Choose a base branch
from
mallardduck:chart-agent-tls
base: release/v2.9
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
force-pushed
the
chart-agent-tls
branch
from
May 16, 2024 23:25
33f9c28
to
6f597ab
Compare
MbolotSuse
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall comments:
- This is missing the logic to maintain
system-store
in case of upgrades - The boolean translation is unnecessary - both the setting and the helm chart value should both be strings
- Be careful on adding validation to "extraEnv" - since that's an existing value, you need to consider backward campatibility if you change that.
mallardduck
force-pushed
the
chart-agent-tls
branch
from
May 31, 2024 14:10
6f597ab
to
fee5d2f
Compare
@MbolotSuse - if this looks good after re-review I will create PRs for 2.8/2.7 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
TODO:
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
Summary: The tests verify all expected results based on potential valid inputs.
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: