Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI chart support to repositories pages #10907

Merged
merged 13 commits into from
May 21, 2024

Conversation

momesgin
Copy link
Member

Summary

Fixes #9815

Occurred changes and/or fixed issues

Added a third option to the radio buttons on the repositories pages to support creating OCI charts.

Technical notes summary

Areas or cases that should be tested

All the requirements on the issue.

Areas which could experience regressions

To be safe we should test the other two types of cluster repos as well, i.e. Helm Url and Git Repo

Screenshot/Video

will be added soon

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.9.0 milestone Apr 30, 2024
@momesgin momesgin self-assigned this Apr 30, 2024
@momesgin momesgin marked this pull request as draft April 30, 2024 17:02
@rohitsakala
Copy link
Member

The type in this screenshot should be changed from http to OCI

Screenshot 2024-05-06 at 1 03 44 AM

Copy link
Member

@rohitsakala rohitsakala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type OCI

@momesgin momesgin marked this pull request as ready for review May 16, 2024 21:41
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momesgin momesgin merged commit f0b0f93 into rancher:master May 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use OCI Helm Chart Registry in Apps&Marketplace
3 participants