Bugfix: Additional links on project page were breaking. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l did not contain slashes after the domain name.
|
I had the same problem, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If and additional link on a project page did not contain a slash after the domain name then it would be assigned an empty link title and the link would therefore be invisible.
www.domainname.com pattern results in the bug as seen here:
http://grab.by/uKew
Where as www.domainname.com/no-bug pattern seems to work fine.
As a fix I've implemented a simple check to bypass domains with no post-fix url information to be ignored from the stripping routine.