Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all headers with byte buffers into presets #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

israpps
Copy link
Contributor

@israpps israpps commented Sep 23, 2022

No description provided.

@ramapcsx2
Copy link
Owner

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

@israpps
Copy link
Contributor Author

israpps commented Sep 23, 2022

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

Hi!

Not sure tbh

I do the PRs as I delve more into this project...

This PR was an idea I got after uploading the sketch into my esp8266

@israpps
Copy link
Contributor Author

israpps commented Sep 23, 2022

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

Hi!

Not sure tbh

I do the PRs as I delve more into this project...

This PR was an idea I got after uploading the sketch into my esp8266

Although, keeping structural changes separated in their own commits seems like a sane idea for the git history.

So maybe 1 PR per large change?

So you can use squash and merge to keep all related changes in one commit

@ramapcsx2
Copy link
Owner

Well, I can say that the history for this project is not that important.
It's super messy already, and anything of value is already buried deep within multiple way too large code change commits.

So on that note, I'm good with however you wanna tackle it. If you need anything merged, please just say so in the merge comment, and I'll do it right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants