add ziptree package for sharing code #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songmu
force-pushed
the
ziptree
branch
3 times, most recently
from
159ec58
to
6992c86
Compare
Songmu
changed the title
Songmu
changed the title
Songmu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are almost the same code for zipping is written in statik.go and fs_test.go, and it is difficult to prove the correctness of the test.
Therefore, I create the ziptree package to share code and utilize it in statik.go and fs_test.go.
Also, the ziptree package's public interfaces are useful for writing custom code for "go generate" to Register original data and create New http.FileSystem, for example, when we want to create multiple file systems.
How do you think?