Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gofmt compability #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jonaz
Copy link

@jonaz jonaz commented Feb 27, 2020

Resolves: #106

@jcchavezs
Copy link
Collaborator

Would you be up to add a gofmt check in the generated example on CI (see https://github.com/rakyll/statik/blob/master/.travis.yml#L13)?

@jonaz
Copy link
Author

jonaz commented Feb 28, 2020

Would you be up to add a gofmt check in the generated example on CI (see https://github.com/rakyll/statik/blob/master/.travis.yml#L13)?

done!

@@ -6,9 +6,8 @@ import (
"github.com/rakyll/statik/fs"
)


const Web = "web" // static asset namespace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is needed because you use the literal "web" here but if you really need this constant then it should be private.

Copy link
Author

@jonaz jonaz Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only ran whats in .travis.yml and it generated that file. ( ./statik -f -src=./example/public -dest=./example/ -include=*.jpg,*.txt,*.html,*.css,*.js -ns=web)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong indentation is not gofmt ok
2 participants