Add Cool.nomark in 6.e #5562
Merged
Add Cool.nomark in 6.e #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in Raku/problem-solving#427 Notes on implementation: - Cool.nomark converts to string and delegates to Str.nomark - in Str.nomark: check if empty string, return invocant if so - decompose the string, return invocant if same number of elements (aka: no codepoint was decomposed) - check each codepoint, only add to buffer if not a mark - convert back to string and return For strings with no marks, this is about 11x faster than using .samemark for a string of 20 characters. For a string with 20 characters with marks, this is about 1.5x as fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in Raku/problem-solving#427
Notes on implementation:
For strings with no marks, this is about 11x faster than using .samemark for a string of 20 characters. For a string with 20 characters with marks, this is about 1.5x as fast.