Deprecate IO subs that operate on multiple paths in 6.e #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires some general consensus |
ugexe
added a commit
to Raku/roast
that referenced
this pull request
Dec 3, 2023
This changes various cleanup code to operate on a single file at a time instead of using the multi-path subroutines. see: rakudo/rakudo#5485
ugexe
force-pushed
the
ugexe/deprecate-multi-file-operations
branch
2 times, most recently
from
4c0a46b
to
95bdb71
Compare
|
Can we make it 6.e only? I generally concur, but best if we don't touch 6.c/d. |
ugexe
force-pushed
the
ugexe/deprecate-multi-file-operations
branch
from
95bdb71
to
74f01d0
Compare
ugexe
changed the title
ugexe
force-pushed
the
ugexe/deprecate-multi-file-operations
branch
from
74f01d0
to
5951684
Compare
|
I've made the changes apply to |
|
I think @lizmat can explain better as I wasn't closely following the recent changes to the roast, but the first rule: have tests for each version with explicit |
ugexe
force-pushed
the
ugexe/deprecate-multi-file-operations
branch
from
5951684
to
4ceca13
Compare
While convienient, being able to pass multiple paths to e.g. &rmdir
is problematic because there isn't a blessed way to handle what to
do when an exception or failure occurs, i.e. should it try to rmdir
every entry even if some things fail, or stop on the first failure?
Previously `rmdir("doesn't exist", "also doesn't exist")` would
return an empty array with no indication of what the failure was.
Yet `("doesn't exist", "also doesn't exist").grep(*.IO.rmdir)
does get failures for these. This difference in behavior is not
intuitive.
This changes subroutines that act on multiple paths by adding a
single path variant, as well as deprecating the multi file variant.
The inclusion of a single path variant is a breaking change, as
these subroutines will now return a failure instead of an array.
ugexe
force-pushed
the
ugexe/deprecate-multi-file-operations
branch
from
4ceca13
to
bd64aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While convienient, being able to pass multiple paths to e.g. &rmdir is problematic because there isn't a blessed way to handle what to do when an exception or failure occurs, i.e. should it try to rmdir every entry even if some things fail, or stop on the first failure?
Previously
rmdir("doesn't exist", "also doesn't exist")would return an empty array with no indication of what the failure was. Yet `("doesn't exist", "also doesn't exist").grep(*.IO.rmdir) does get failures for these. This difference in behavior is not intuitive.This changes subroutines that act on multiple paths by adding a single path variant, as well as deprecating the multi file variant. The inclusion of a single path variant is a breaking change, as these subroutines will now return a failure instead of an array.