First attempt to use a dispatcher instead of nqp::p6definite #5456
+50
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently needs taking care about `$v.VAR.DEFINITE` case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this PR patches the legacy parser, but it was inspired by @MasterDuke17 notice about getting rid of
nqp::p6family altogether for the better optimizations of new-disp approach. So, would make better sense with RakuAST.Currently needs taking care about
$v.VAR.DEFINITEcase where it erroneously reportsFalse. From the point of view of a dispatcher there is no difference if it is$v.DEFINITEor$v.VAR.DEFINITE. Therefore the most likely solution would be to somehow know that the invocant is a.VARcall and signal this fact via an extra argument of the dispatcher.