Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Capture an object type #5291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Capture an object type #5291

wants to merge 1 commit into from

Conversation

lizmat
Copy link
Contributor

@lizmat lizmat commented Jun 20, 2023

Rather than a value type, which it is not as it can have mutable elements. See Raku/problem-solving#372 for more information.

This causes:

  • t/spec/S14-roles/attributes-6e.t
  • t/spec/S14-roles/composition.t

to fail. Both seem to be related to WALK incorrectly assuming equivalence at some level.

Rather than a value type, which it is **not** as it can have mutable
elements.  See Raku/problem-solving#372
for more information.

This causes:
- t/spec/S14-roles/attributes-6e.t
- t/spec/S14-roles/composition.t

to fail.  Both seem to be related to WALK incorrectly assuming
equivalence at some level.
@lizmat
Copy link
Contributor Author

lizmat commented Jun 20, 2023

@vrurg the failures appear .WALK related, which feels up your alley?

@vrurg
Copy link
Member

vrurg commented Jun 20, 2023

No idea what's going on. There is even no any diagnostics to look at.

The only thing I see for now is that neither the WALK method, nor the WalkList class do any operations on captures. WALK itself does nothing at all, WalkList actually captures arguments to transfer them to the actual methods it invokes. No equality checks whatsoever.

So, I think it's something more fundamental.

@lizmat
Copy link
Contributor Author

lizmat commented Jun 20, 2023

@vrurg Ack. Thanks for checking!

@raiph
Copy link
Contributor

raiph commented Jun 21, 2023

Both seem to be related to WALK incorrectly assuming equivalence at some level.

cf @jnthn:

it'd make sense for snapshot equality (eqv) to work.

Is there a connection between these two comments?

@lizmat
Copy link
Contributor Author

lizmat commented Jun 21, 2023

No, not that I know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants