New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compability check actually checks the type for files #1251

Open

kannibalox wants to merge 1 commit into rakshasa:master from kannibalox:fix/check-file-target

Contributor

kannibalox commented Oct 1, 2023

I'm actually not entirely sure if the other two checks are still necessary, but kept them in case there were some side effects I don't know about.

Fixes #854


          Ensure compability check actually checks the type for files

38efb87

Fixes rakshasa#854

kannibalox force-pushed the fix/check-file-target branch from 6d12b80 to 38efb87 Compare

October 6, 2023 04:20

Contributor Author

kannibalox commented Oct 6, 2023

I have now grokked the two existing checks, and element_file_list.cc no longer throws an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment