Define colors for the integrated terminal #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets g:terminal_ansi_colors using the already-defined variables. It makes terminal apps look normal, by setting the 16 default colors. See the Vim help for term_setansicolors()
|
Terminal color was removed on #104 because the colors were inconsistent when using a light theme. I second to re-add the colors, provided that we add support to the light theme too. |
|
These colors use the variables defined by the theme, like
Other terminal apps also look OK (actually I'm not at all a fan but actual light mode users can judge whether this looks correct 😁):
|
Closed
|
Due to inactivity from the maintainers, I've merged this (and some other long-standing PR's) into my fork: rvighne#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the 16 default colors within the Vim 8 integrated terminal (via
g:terminal_ansi_colors) so that terminal apps look as expected. The colors are in terms of the already-defined variables, so it should stay consistent and work in light mode too.Here's a comparison with from Windows Terminal. Note that WT decided to use a very bright color for white, but I've chosen to stick with the colorscheme so it looks better next to actual editor buffers.