Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri): select ledger wallet by derivation index #509

Closed
wants to merge 9 commits into from

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Mar 30, 2024

Resolves #290

  • Adds a dropdown to all ledger inputs to "Select by Derivation Index"
  • Fetches 5 addresses starting from derivation index 0
  • Clicking "Load More" fetches the next 5 addresses

todo

image
image
image

@thedavidmeister thedavidmeister changed the base branch from 2024-03-28-ui-connect-wallet to main April 1, 2024 09:01
@hardyjosh hardyjosh requested review from thedavidmeister and hardyjosh and removed request for thedavidmeister May 13, 2024 09:25
@hardyjosh
Copy link
Contributor

@thedavidmeister I had to bump alloy-ethers-typecast on rainlanguage/rain.interpreter#236 and then bumped rain.interpreter here.

that's giving me CI issues now for the sol prelude

@hardyjosh
Copy link
Contributor

Closing, while trying to complete it I realised that the whole way we're handling wallets needs overhauling - what we have after merging this PR isn't good enough. We can reopen at a later date if we want.

@hardyjosh hardyjosh closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select a ledger address rather than requiring user to enter derivation index
3 participants