Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-ecs-task not to fail if deployments are not returned in describe services response #53

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

IgorDobryn
Copy link
Collaborator

Motivation

Fix github action not to fail if no deployments in service response

How to test

  • Make sure there are no ongoing deployments
  • Run ecs task. I.e. ACTIONS_RUNNER_DEBUG=true AWS_SDK_LOAD_CONFIG=1 AWS_PROFILE=railsware AWS_REGION=us-east-1 yarn run_action --action run-ecs-task --cluster my-cluster --service my-service --container my-container --command 'echo "Hello World"' --task-definition 'my-task-definition-arn' --wait-for-completion true --show-raw-output false
  • Assert command does not fail

…scribe services response

Co-authored-by: Volodymyr Pihol <volodymyr.pihol@railsware.com>
@IgorDobryn IgorDobryn merged commit 9b3c4f6 into master Nov 2, 2023
2 checks passed
@IgorDobryn IgorDobryn deleted the fix-run-ecs-task branch November 2, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants