Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase yarn install timeout #1414

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tasks/webpacker/yarn_install.rake
@@ -1,6 +1,6 @@
namespace :webpacker do
desc "Support for older Rails versions. Install all JavaScript dependencies as specified via Yarn"
task :yarn_install do
system "yarn install --no-progress --frozen-lockfile --production"
system "yarn install --no-progress --frozen-lockfile --production --network-timeout 1000000"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making the rake task accept arguments and appending them to the system call.

Would be more flexible IMO.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails during deploy using a buildpack. I am not sure if it is possible to specify a concrete rake task arguments when using a buildpack.

end
end