rTorrent 0.9 #17
Open
rTorrent 0.9 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review this and get back to you. Thanks for the PR.
…On Sun, Mar 22, 2020, 11:33 AM James Kiefer ***@***.***> wrote:
rTorrent 0.9 has deprecated (renamed) many commands
<https://github.com/rakshasa/rtorrent/wiki/rTorrent-0.9-Comprehensive-Command-list-(WIP)>
.
This pull request renames all the commands in the templates/rtorrent.rc.j2
template.
Also, I had some specific needs for directory owner/permissions so I have
included a rework for those settings that provide maximum flexibility.
I can separate these changes if that would make things easier.
------------------------------
You can view, comment on, or merge this pull request online at:
#17
Commit Summary
- Update rtorrent.rc for rTorrent 0.9
- Allow rTorrent directory user and group to be overridden
- Rework directory handling for flexibility
- Bugfix: Recursively combine default and user directories
File Changes
- *M* defaults/main.yml
<https://github.com/rahul0705/ansible-rtorrent/pull/17/files#diff-7eeda618087b49ae876084ab6c73fdbb>
(22)
- *M* tasks/main.yml
<https://github.com/rahul0705/ansible-rtorrent/pull/17/files#diff-2444ad0870f91f17ca6c2a5e96b26823>
(12)
- *M* templates/rtorrent.rc.j2
<https://github.com/rahul0705/ansible-rtorrent/pull/17/files#diff-733614602f9aa1ebdc5a9057536fcbdc>
(40)
- *M* templates/rtorrent.service.initd.j2
<https://github.com/rahul0705/ansible-rtorrent/pull/17/files#diff-96960fe659a3bf316e4dd7c2eff8bd7f>
(20)
- *M* templates/rtorrent.service.systemd.j2
<https://github.com/rahul0705/ansible-rtorrent/pull/17/files#diff-1020535abea718a3b1dd4daad13cdec6>
(2)
Patch Links:
- https://github.com/rahul0705/ansible-rtorrent/pull/17.patch
- https://github.com/rahul0705/ansible-rtorrent/pull/17.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3MAWIEN5STIZDR3KDSITTRIYVWHANCNFSM4LRKUG2A>
.
|
Update the README
|
Good updates (sorry for the long response time). I would also suggest updating the unit tests to ensure its being tested. Overall one additional review comment: We could maintain old compatibility (if its worth while) by versioning the config files and using them based on user defined |
|
That sounds like a good idea but there seem to be other problems now. On Ubuntu 20.04 the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rTorrent 0.9 has deprecated (renamed) many commands.
This pull request renames all the commands in the
templates/rtorrent.rc.j2template.Also, I had some specific needs for directory owner/permissions so I have included a rework for those settings that provide maximum flexibility.
I can separate these changes if that would make things easier.