Eliminate restriction to nightly #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, I let my formatter get away from me. I'll get rid of those. |
I just made a few adjustments that makes this library usable in the Stable toolchain. `is_some_and` is in stable as of `rustc` 1.77.2, so that feature macro could be removed entirely. Use of the nightly bencher is now blocked behind a feature flag called "nightly".
williamareynolds
force-pushed
the
feature/substriber
branch
from
bec31e4
to
33a6275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just made a few adjustments that makes this library usable in the Stable toolchain.
is_some_andis in stable as ofrustc1.77.2, so that feature macro could be removed entirely. Use of the nightly bencher is now blocked behind a feature flag called "nightly".Thank you for writing this little library! I'm new to Rust myself, so doing all this on my own was daunting. I hope these changes can help others who come along and find trouble with the feature macro like I did. Please let me know if you'd like to see any other changes!