New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gnomeTheme.noThemedIcons #763
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request miss in the readme.md under Enabling optional features, the name of the switch and what he does (if not documented nobody will know it exist).
Also @rafaelmardojai need (to check if it actually working), nothing personal but with the increasing number of AI made pull request It must be checked.
Just updated the README. Sorry if this PR looks a bit hacky - I initially didn't intend to make this public, just thought might be a good idea to contribute back. I haven't really opened PRs before so please tell me if I'm doing anything wrong |
Ahah it's exactly how I started maintaining the vertical tab at first it was 3 hack patched together with time I used myself the toolbox of firefox to make it properly xD And I had also forgotten the readme (why I told you since I had the same error at my first here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for contributing.
Code looks good overall, I will give it a try in the weekend.
The only problem I found now is that you're not using tabs for indentation, I may standardize the CSS style in the future and maybe move to using spaces, but for now please use tabs to be consistent with the document.
Added a way to allow original icons from Firefox to be used