Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to ESLint flat config #907

Merged
merged 6 commits into from May 16, 2024

Conversation

DamianGlowala
Copy link
Contributor

No description provided.

@zernonia
Copy link
Collaborator

Thanks for the PR @DamianGlowala ! However it's throwing error when I run pnpm lint:fix

image

@DamianGlowala
Copy link
Contributor Author

@zernonia just checked and it's working on my end. Have you installed dependencies and run pnpm lint:fix at the root of the repo?

@zernonia
Copy link
Collaborator

Yup. I've removed pnpm-lock and node_modules to make sure clean installation. But the problem still exists. Seems like there's something wrong with Plugin renaming 😅

Can you try clean installation too?

@DamianGlowala
Copy link
Contributor Author

@zernonia could you please check it now? 😄

Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! It works perfectly now @DamianGlowala !! Thanks for the effort and taking time to look into those problem 🙏🏻!

@zernonia zernonia merged commit fd92219 into radix-vue:main May 16, 2024
3 of 4 checks passed
@DamianGlowala DamianGlowala deleted the feat/eslint-flat-config branch May 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants