Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tailwind demos #775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryanleichty
Copy link
Contributor

There were a number of inconsistencies that I noticed when using the Tailwind examples, so this PR makes everything more consistent.

  • Updated a number of redundant arbitrary classes with native Tailwind classes.
  • Sorted all tailwind classes using the prettier-plugin-tailwindcss.
  • Fixed a few incorrect classes in the process of sorting (e.g.: color-white to text-white). The prettier-plugin-tailwindcss plugin moves unrecognized classes to the beginning of the string which can help find incorrect classes.

It might be worth considering adding the Radix design system within the Tailwind config files versus using arbitrary values for the spacing scale. I found a number of old design system values, but wasn't 100% positive which were used for the primitives when they were first created.

This pull request:

  • Fixes a bug
  • Adds additional features/functionality
  • Updates documentation or example code
  • Other

Updated a number of redundant arbitrary classes with native Tailwind classes. There were a number of inconsistencies that I noticed when using the Tailwind examples as a starting place, so this smoothes things out.

It might be worth considering adding the Radix design system within the Tailwind config files versus using arbitrary values for everything. I found a number of old design system values, but wasn't 100% positive which were used for the primitives when they were first created.
- Sorted all tailwind classes using the `prettier-plugin-tailwindcss`
- Fixed a few incorrect classes in the process (e.g.: `color-white` to `text-white`). The plugin moves unrecognized classes to the beginning of the string which can help find incorrect classes.
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radix-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:37pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant