Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default target_chunksize #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Member

I think 1e6 is probably a more sensible value in case cubes are rechunked to combine chunks along any of the dimensions.

@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #11 (366b6d1) into main (a077f37) will decrease coverage by 39.92%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   93.72%   53.80%   -39.93%     
===========================================
  Files           4        4               
  Lines         526      526               
===========================================
- Hits          493      283      -210     
- Misses         33      243      +210     
Impacted Files Coverage Δ
casa_formats_io/casa_dask.py 11.57% <0.00%> (-83.48%) ⬇️
casa_formats_io/casa_wcs.py 22.72% <0.00%> (-75.76%) ⬇️
casa_formats_io/casa_low_level_io.py 87.36% <0.00%> (-3.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a077f37...366b6d1. Read the comment docs.

@astrofrog astrofrog requested a review from keflavich March 4, 2021 19:08
@astrofrog astrofrog force-pushed the reduce-default-target-chunksize branch from 366b6d1 to b05c0ce Compare December 7, 2021 14:07
@astrofrog astrofrog force-pushed the reduce-default-target-chunksize branch from b05c0ce to 6d30f97 Compare September 23, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants