Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use darshan config file #663

Merged
merged 16 commits into from May 3, 2024
Merged

use darshan config file #663

merged 16 commits into from May 3, 2024

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Apr 10, 2024

No description provided.

@mtitov mtitov self-assigned this Apr 10, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 59.70149% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 71.62%. Comparing base (9d05579) to head (d8692e7).
Report is 11 commits behind head on devel.

Files Patch % Lines
src/radical/entk/tools/darshan.py 57.37% 26 Missing ⚠️
src/radical/entk/appman/appmanager.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #663      +/-   ##
==========================================
+ Coverage   71.46%   71.62%   +0.15%     
==========================================
  Files          26       26              
  Lines        2250     2308      +58     
==========================================
+ Hits         1608     1653      +45     
- Misses        642      655      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov mtitov marked this pull request as ready for review May 2, 2024 00:24
@mtitov mtitov requested a review from andre-merzky May 2, 2024 00:24
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all reasonable to me.

@mtitov mtitov merged commit 5a0f335 into devel May 3, 2024
4 checks passed
@mtitov mtitov deleted the fix/darshan_cfg branch May 3, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants