Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/darshan #661

Merged
merged 14 commits into from Mar 20, 2024
Merged

Fix/darshan #661

merged 14 commits into from Mar 20, 2024

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Feb 27, 2024

Updated Darshan integration based on the latest experience of using it

@mtitov mtitov self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 72.05882% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 71.46%. Comparing base (dec1451) to head (56c8485).

Files Patch % Lines
src/radical/entk/tools/provenance.py 22.22% 28 Missing ⚠️
src/radical/entk/tools/darshan.py 91.39% 8 Missing ⚠️
src/radical/entk/appman/wfprocessor.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #661      +/-   ##
==========================================
+ Coverage   71.33%   71.46%   +0.13%     
==========================================
  Files          23       26       +3     
  Lines        2114     2250     +136     
==========================================
+ Hits         1508     1608     +100     
- Misses        606      642      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov mtitov marked this pull request as ready for review February 28, 2024 22:38
@mtitov
Copy link
Contributor Author

mtitov commented Mar 1, 2024

todo:

  • add more tests

@mtitov mtitov marked this pull request as draft March 1, 2024 17:03
@mtitov mtitov marked this pull request as ready for review March 19, 2024 18:01
@mtitov
Copy link
Contributor Author

mtitov commented Mar 19, 2024

@andre-merzky ready for review

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtitov, the code looks reasonable to me.

What I am missing is some explanation what Darshan actually is and what it is used for. For example: some methods are public methods and will show up in RTD, but don't have a docstring, so the user is left guessing what this is about.

src/radical/entk/tools/darshan.py Show resolved Hide resolved
src/radical/entk/tools/darshan.py Show resolved Hide resolved
src/radical/entk/tools/darshan.py Show resolved Hide resolved
src/radical/entk/tools/darshan.py Show resolved Hide resolved
src/radical/entk/tools/darshan.py Outdated Show resolved Hide resolved
src/radical/entk/tools/darshan.py Outdated Show resolved Hide resolved
@mtitov mtitov mentioned this pull request Mar 20, 2024
3 tasks
@mtitov mtitov merged commit 9d05579 into devel Mar 20, 2024
4 checks passed
@mtitov mtitov deleted the fix/darshan branch March 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants