Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ob to oi and omb to ob #21426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Lazula
Copy link
Collaborator

@Lazula Lazula commented Mar 3, 2023

Partial #11988

Resolves:

  • Rename ob to oi
  • Rename omb to ob
  • Rename objid to binfd in ob? (now oi?)

@Lazula Lazula added the abibreak this commit/issue/ticket breaks the current ABI label Mar 3, 2023
@radare
Copy link
Collaborator

radare commented Mar 6, 2023

Let's hold this pr for 5.9, also despite i think its a reasonable change because it reuses commands in a better way i would like to discuss about the change and explain it properly when applied because it will break more than one script

@Lazula Lazula added the cmdbreak The change introduces backward incompatible commands label Mar 6, 2023
@Lazula Lazula added this to the 5.9.0 milestone Mar 6, 2023
@trufae
Copy link
Collaborator

trufae commented Feb 18, 2024

Unfortunately this change needs to resolve the conflicts and may require more discussion to clarify those command changes to not break scripts here and there. im moving this PR for a near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abibreak this commit/issue/ticket breaks the current ABI cmdbreak The change introduces backward incompatible commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants