Add import graph (agi) + new ag? help #10132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed agg? help Removed unused variable warning
Fix of string arguments in ag* commands Fix whitespace
radare
reviewed
May 19, 2018
libr/core/cmd_anal.c
Outdated
| "agv", "", "Show function graph in web/png (see graph.web and cmd.graph) or agf for asciiart", | ||
| "Usage:", "ag<graphtype><format> [addr]", "", | ||
| "Graph types:", "", "", | ||
| "c", " [fcn addr]", "Function callgraph", |
There was a problem hiding this comment.
you shuold put the whole command in here, otherwise it will break ?* to enumerate all recursive commands
radare
reviewed
May 19, 2018
libr/core/cmd_anal.c
Outdated
| @@ -5992,6 +5982,28 @@ static void cmd_anal_graph(RCore *core, const char *input) { | |||
| break; | |||
| } | |||
| break; | |||
| case 'i': // agi "import graph" | |||
There was a problem hiding this comment.
put quotes around "agi", we use this to find where the commands are implemented by greeping for this expresssion which have very few false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the import graph, which is basically a cross-references graph to all the imports.
Also, since all graph types are mostly done, I decided that it was time to update ag? help.
I also changed
agvcommand, which before behaved likeagfw: now it is just an alias foragfv, to remain consistent with thevformat character (interactive ascii) of the other ag commands.Fixed one or two things from my last pr (in particular, there was a compiler warning about unused variables).
After this pr what's left to do is addressing some issues with argument handling (the infamous agj @ 0) and adding capital letters for global graphs (which shouldn't be difficult) and then I think I'll have finished with ag*