[WIP] Show unicode strings in disasm

[cyanpencil]

Shows flag realnames instead of names in disasm if scr.utf8 is enabled.
String flag realnames are now unfiltered version of flag names.

To test this:
download this binary http://xvilka.me/chinese and then:

r2 -A chinese
> e scr.utf8=1
> s 0x0040055a
> pd 1

---

This is a [WIP] pr because it doesn't affect only unicode languages, but also english binaries, in fact if utf8 is enabled instead of
str.A_string_with_spaces
we will have
str.A string with spaces

However, all commands will still need normal flag names. Please test this, and tell me if it creates confusion.

[cyanpencil]

r2r pr: https://github.com/radare/radare2-regressions/pull/1383

[XVilka]

@cyanpencil maybe wait until you do the character lengths, then merge - so far it looks very simple and good.

[radare]

maybe if we do this we can kill the str. and use quotes around the string, and flags or refs can be followed by using Vr (toggle leahints instead of jmphints), so the option to make this happen doesnt needs to be enabled by default or break anything

[radare]

dont reuse utf8 option for this, add another option pls, and make this option live inside RFlag, so you dont have to pass that option as argument all the time

[radare]

this new option can be named. asm.flags.real or

[XVilka]

Good idea about using "string" instead of str.string, this makes more sense, agree.

[XVilka]

@radare why 2.8.0? if we put it in 2.7.0 but disabled by default, it might be better for testing

[cyanpencil]

Ok, I'll change the utf8 option and use "string" instead of str.string. Also will leave it Work In Progress until the character legth pr is not merged (I'll push it today, almost finished)

[cyanpencil]

Done, now this should work without changing the r2r tests, since asm.flags.real is disabled by default.

[cyanpencil]

There are some testcases broken like this:

-            ;-- str.Hello World:
+            ;-- "Hello World":

[XVilka]

Strange, it shows 29 broken tests.

[XVilka]

Can you please rebase both r2r and this pull requests?

[radare]

uhm, not sure if red because of the pr or master being red. we sohuld greenify travis first

[ret2libc]

@cyanpencil what happens if there are control chars in the string? Newline, delete chars, etc.

[cyanpencil]

@XVilka yes I made a mess in the last commit + with rebasing, am currently fixing

@ret2libc I quickly tested on a binary that has a string like this "A\x01\x02...\x1f" (which should be all control chars) and r2 correctly escaped them by showing "A\a\b\t\n...", so I suppose it works, but didn't test it much more

[cyanpencil]

Ok green again.
P.s: I also updated the r2r pr: https://github.com/radare/radare2-regressions/pull/1383

[XVilka]

Merged. It will be easier to test now.