Remove ascii arrows from disassembly widget

[xarkes]

Needs to fix pdJ with scr.html=true some characters aren't parsed correctly.
Needs to fix some fcnlines in radare2 too, cf screenshot below.

[Maijin]

@thestr4ng3r ^

[thestr4ng3r]

Do you have an example what exactly needs to be fixed in pdJ?

[xarkes]

I can't send a screenshot but the fcnlines character when utf8 is enabled is printed as \xe4\xXX\xXX something and it should be converted to a single character when using scr.html=true. The same way that \x1b for ansi codes is changed to <font color="#xxxxxx">

[ITAYC0HEN]

Screenshots attached.
Also, while scrolling with the wheel, it changes where and how the lines are.

[xarkes]

I tried with this dumb patch:

diff --git a/libr/core/disasm.c b/libr/core/disasm.c
index fd83d10f4..a2bd2e50f 100644
--- a/libr/core/disasm.c
+++ b/libr/core/disasm.c
@@ -1729,7 +1729,8 @@ static void ds_print_pre(RDisasmState *ds) {
 
        char *c_esc = NULL;
        if (ds->use_json) {
-               c = c_esc = r_str_escape (c);
+               //c = c_esc = r_str_escape (c);
+               c = c_esc = strdup (c);
        }
        r_cons_printf ("%s%s%s ",
                COLOR (ds, color_fline), c,

Now the utf-8 characters are properly shown, but it looks like the characters are not vertically aligned anymore.

[XVilka]

See also radareorg/radare2#10555

[Maijin]

CC @cyanpencil

[XVilka]

Wasn't this fixed already?

[xarkes]

No, otherwise the issue would be closed :)

[ITAYC0HEN]

@xarkes your fix works fine - the problem with the vertical alignment is in the font being used. I assume
Inconsolata doesn't support some characters such as "─" or ">" so the character is being printed with a different font that has different char-width.

Inconsolata (Default font):

Free Mono:

[XVilka]

Open a bug in Inconsolata.

…

On Fri, Aug 17, 2018, 11:19 PM Itay Cohen ***@***.***> wrote: @xarkes <https://github.com/xarkes> your fix works fine - the problem with the vertical alignment is in the font being used. I assume Inconsolata doesn't support some characters such as ">" so the character is being printed with different font that has different char-width. *Inconsolata (Default font):* [image: inconsolata] <https://user-images.githubusercontent.com/20182642/44273958-96bbc300-a249-11e8-9dcc-ae51af518aed.JPG> *Free Mono:* [image: freemono] <https://user-images.githubusercontent.com/20182642/44273960-98858680-a249-11e8-97a8-b490f53d72a9.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/radareorg/cutter/issues/413#issuecomment-413899191>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMZ_aMjB6PBYqmixH3HONi62sPb8RZQks5uRt72gaJpZM4SzQij> .

[xarkes]

Great, maybe we can change default font in Cutter and then merge the fix.

[ITAYC0HEN]

I love Consolas. What do you think? Didn't check the alignment with it, though

…

On Mon, Aug 20, 2018, 10:18 xarkes ***@***.***> wrote: Great, maybe we can change default font in Cutter and then merge the fix. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/radareorg/cutter/issues/413#issuecomment-414220356>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATP2cqKhPIhRXS_I0zVP1TcnAeMtJbbQks5uSmLegaJpZM4SzQij> .

[radare]

agave is nice too. i put some nice console fonts in my Therm (iterm2 fork) if u want to check them too

[thestr4ng3r]

Yeah agave is great. Looks really nice in cutter.

[xarkes]

Screenshots? :P

[radare]

cant change the font :P already filled an issue about this

…

On 20 Aug 2018, at 12:20, xarkes ***@***.***> wrote: Screenshots? :P — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/radareorg/cutter/issues/413#issuecomment-414268490>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lu_HjpShtRWqtJfi9By4JsuK0gh0ks5uSo1QgaJpZM4SzQij>.

[thestr4ng3r]

agave:

Vertical lines don't look too good, but maybe that can be fixed somehow. I like the font though.

[xarkes]

Yeah I like the font too, and I don't really mind if the lines are a bit broken. As you said I think it can be fixed with the line height.

[ITAYC0HEN]

It's too heavy imo. I prefer thinner fonts. Maybe there's a thinner version
Also, yeah, no continuous lines :(

[ITAYC0HEN]

okay so we need to decide on the right font to use and finally get rid of the dashed lines in cutter

|
|
|
|

[xarkes]

I think we just need to stop relying on r2 output when it comes to our interface.
All we need from 2 is the disassembly, we should draw our own arrows.
I am renaming this issue.

[XVilka]

Exactly, it will help to solve also 1) selection problem (don't select opcode bytes and reflines) 2) folding 3) highlighting and colors.

[ITAYC0HEN]

the solution is a WIP and almost done. Tracked by @xarkes here: https://github.com/radareorg/cutter/tree/disassemblyWidget

[ITAYC0HEN]

Pullrequest is pending: https://github.com/radareorg/cutter/pull/1626