Revert to old graph edges positioning (added an option) #10430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanpencil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10400
Added option that reverts to old method of positioning edges. This option is on by default, since old edges were better in most cases. I will continue and try to finish the new edges before release.
This is better than reverting my last graph edges pr since it fixed other small things too (like enlarging of nodes with many edges, and some improvements on vertical layout)
I had changed a test in that pr, so here is that test reverted: https://github.com/radare/radare2-regressions/pull/1364
ALSO I included a typo fix in canvas.c that I forgot in my last pr