-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Centralised Logging #275
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 111 112 +1
Lines 5131 5141 +10
Branches 281 281
=======================================
+ Hits 4971 4981 +10
Misses 128 128
Partials 32 32
Continue to review full report at Codecov.
|
I think the way this is supposed to work is as follows:
import logging
log = logging.getLogger("<logger name>")
log.info("Message goes here", extra={}) We probably want to send different logs to different |
Hi Daniel, I just got around to check this PR. It's incredible what you have implemented. Can we use https://docs.python.org/3/library/logging.handlers.html#sysloghandler instead? |
record.time = datetime.now() | ||
del record.request | ||
record.level = record.levelname | ||
# TODO: Get user details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't log user details. We need to obey to GDPR
This is very WIP.