Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: auto DHE, ECDHE #4412

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

openssl: auto DHE, ECDHE #4412

wants to merge 6 commits into from

Commits on Aug 25, 2022

  1. openssl: mark functions deprecated in OpenSSL 3.0.0

    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5a4c3f4 View commit details
    Browse the repository at this point in the history

  2. openssl: auto ECDHE, change ssl-server-context-enable-ecdhe! to no-op 

    Since v1.1.0, ECDH is always enabled with auto curve selection,
and customizing curves is rarely needed or advisable.
For v1.0.2, set auto-selection in server context construction.

See openssl/openssl#8837 (comment)
    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e2eca30 View commit details
    Browse the repository at this point in the history

  3. openssl: auto DHE, update ssl-server-context-enable-dhe! 

    Recent advice from OpenSSL developers seems to be to just use
`SSL[_CTX]_set_dh_auto`, which picks a common group based on the
certificate's key strength and current security level.  Some
discussions:
- https://www.mail-archive.com/openssl-users@openssl.org/msg90995.html
- https://www.mail-archive.com/openssl-users@openssl.org/msg85573.html
- https://www.spinics.net/lists/openssl-users/msg10099.html

Another reasonable choice is to use one of the dhparams from RFC 7919.

There is an argument for a custom dhparams: to avoid precomputation
attacks on popular groups (see weakdh.org), but the old dhparams file
was copied from openssl, not custom-generated anyway.

Drop SSL_OP_SINGLE_DH_USE; it is ignored since v1.0.2f.

... DH
    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e78fb4d View commit details
    Browse the repository at this point in the history

  4. openssl: delete support for non-auto ssl-server-context-enable-dhe! 

    This makes the procedure a no-op (except possibly logging a warning).
This commit can be reverted if finer control over DHE groups is needed.
    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    3bbfe1d View commit details
    Browse the repository at this point in the history

  5. openssl: update docs for DHE, ECDHE changes

    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b9160c9 View commit details
    Browse the repository at this point in the history

  6. openssl: delete dh4096.pem, no longer used

    @rmculpepper
    rmculpepper committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    1e5ad6b View commit details
    Browse the repository at this point in the history