Add logging unit tests to locator #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablease
force-pushed
the
test-logging-locator
branch
from
de0e74b
to
247e15f
Compare
Zerpet
reviewed
Sep 26, 2023
ablease
force-pushed
the
test-logging-locator
branch
from
5bfec62
to
4a5a2f6
Compare
Zerpet
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new logging Context for the locator tests.
The Stream suite adds a custome handler to handle Debug level logs, and writes them to the GinkgoWriter.
In the locator tests, we Tee the logs into a seperate buffer, and make assertions on the structured logs in this buffer.