-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore ebusy
when deleting a directory
#11066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukebakken unlike with enoent
, should ebusy
lead to a (limited) number retries with sleeps in between?
Which would require a slightly larger change.
According to So looks like we must retry up to N times with a delay in between (of, say, 5ms?) |
A retry won't fix the issue with |
6ddd380
to
f45a262
Compare
f45a262
to
ab909c3
Compare
Reported in #11047 This error manifests when the quorum directory is its own mount point
A folder can be a mount point and the kernel won't allow deleting a mount point - it will return ebusy We don't need to check for ebusy when deleting a file
msg_stores is a potential mount point and therefore might exist
ab909c3
to
c9fcc4d
Compare
The force-push was a rebase. |
An additional investigation suggests that when there are two overlapping directories on two different Linux mounts (at least with EBS volumes), for instance
then the node won't be able to delete |
@Mergifyio backport v3.13.x |
✅ Backports have been created
|
Ignore `ebusy` when deleting a directory (backport #11066)
Reported in #11047
This error manifests when the quorum directory is its own mount point.