Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2: log out from IDP only when an end_session_endpoint is available #11064

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Apr 23, 2024

Proposed Changes

Implements this feature request.

This PR is accompanied by a docs PR that explains the different behaviour of the logout action depending on the availability of the end_session_endpoint attribute of the OpenId Connect discovery endpoint.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality), closes OpenID Connect RP-Initiated Logout should be optional  #11067
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

And use appropriate selenium docker image
based on arch
@MarcialRosales MarcialRosales self-assigned this Apr 23, 2024
@MarcialRosales MarcialRosales marked this pull request as ready for review April 23, 2024 12:48
@michaelklishin michaelklishin changed the title Logout from idp only when end_session_endpoint is available OAuth 2: log out from IDP only when an end_session_endpoint is available Apr 23, 2024
@michaelklishin michaelklishin merged commit 483a824 into main Apr 23, 2024
18 checks passed
@michaelklishin michaelklishin deleted the make-end-session-endpoint-optional branch April 23, 2024 19:24
michaelklishin added a commit that referenced this pull request Apr 24, 2024
OAuth 2: log out from IDP only when an end_session_endpoint is available (backport #11064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants