Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use responsive images #303

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jefferyto
Copy link

These changes work with the built-in responsive image functionality added in WordPress 4.4, to allow browsers to download smaller images when possible.

These changes affect:

  • Content images
  • Featured images
  • Post covers (both "regular" and with post titles overlaid on top)
  • Custom header image

These changes are modelled after similar code in the Twenty Sixteen and Twenty Seventeen themes. (Current code for these themes are slightly different than their GitHub versions, but its much easier to link to the GitHub versions 馃槅)

I've tried to be as backwards-compatible as possible (both with older versions of WordPress and with IE<9) but TBH I've only tested these changes with the latest browsers and WP (4.9.8).

This works with the built-in responsive image functionality added in
WordPress 4.4, to allow browsers to download smaller versions of content
images and full-width featured images when possible.
@raamdev
Copy link
Owner

raamdev commented Mar 27, 2023

@jefferyto Thanks very much for the PR! I've been slow to work on this project, but I very much appreciate the contributions. I will take a look at merging this for the next release.

I noticed your PR appears to include my changes from #325, so I will likely favor your PR over mine. :-)

@raamdev raamdev added this to the Next Release milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants