Initial commit for mobile menu support. Should work with every combin… #242
Conversation
…ation of layouts and content, except for content that use post cover images. In that case, the site information (title+tagline) is displayed below the post cover, which may not be the desired behaviour.
|
I'm testing this, but it doesn't seem to work at all... I see the menu icon, but all of the page links are showing even when the menu is in its closed state:
Is there something you did to get it working, or am I missing something? |
|
That weird, I've got the branch checked out now, and it works well here. I've only tested this is FF and Chrome on Windows 10, though, might be something that's missing for it to work correctly on your setup. I assume you deleted the browser cache and don't use a WP cache on you dev install? Does the menu always show? Does the menu icon change from a hamburger to an X when you click it? The menu needs CSS3 support to work properly (I did this because 99% of mobile browsers do), but the menu should at least be hidden even for browsers that doesn't support CSS3. The menu is live on my personal site, by the way. |
|
Hmm, odd. It works fine on your site (I'm using Chrome on Mac OS X), but not on my test site. Tried clearing browser cache and I'm not running a caching plugin. I'll have to take a closer look to see what might be wrong. Might tackle that this weekend. I do love the simplicity of the menu though—looks and works great on your site! |
|
Are you running the child theme with some custom CSS? If not, I'll have to take a closer look at my commits to the branch, maybe something is missing. |
|
Nope, not running a child theme or any custom CSS. |
|
All right, thanks. I'm having a hard time figuring out why it doesn't work on your dev setup, especially since it works for you on my personal site. I've got the branch working on my own dev setup, and I've got nothing locally that hasn't been pushed. Is your dev setup available on the internet? It would be interesting to see if it works for me. |
|
This issue is open for a bit, and I just wanted to say, that mobile menu is currently top of missing features - I mean, 50% of most website visitors are coming from mobile. Do you think this will be resolved merged in foreseeable future? Thanks for the response! |
|
@LeBaux If you're the adventurous type, you can download the branch the PR is based on, and give it a try on your own site. I've just merged the master-branch into the PR-branch, so you'll get the most recent version of the theme + the mobile menu. If you decide to go ahead and give it a try, please report back and let me know if the mobile menu works or not. |
|
Just a heads up on this PR. I no longer use the Independent Publisher theme on my site, so I'm not actively trying to get mobile menu support to work. Also, it's been two years since the last release of the theme, and one and a half year since the last commit to the repository by @raamdev. I'm just speculation, but for all intents and purposes, it looks like Independent Published is on an indefinite hiatus. From what I can tell, @raamdev got a job as software engineer with Automattic since the last release of the theme. Well done, Raam, I guess you're doing even more important WordPress-related stuff now :) Good luck, and thanks a lot for your contributions. |
|
@vskjefst Thanks for the update. I'll keep this PR open for now as I intend to continue maintaining the Independent Publisher theme and I may still merge your work here. I've just been quite busy lately and haven't had any time to spare for the theme. 😃 |
…ation of layouts and content, except for content that use post cover images. In that case, the site information (title+tagline) is displayed below the post cover, which may not be the desired behavior.