Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a slightly more friendly message when a student opens an empty file #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw a slightly more friendly message when a student opens an empty file #99

wants to merge 1 commit into from

Conversation

ausbin
Copy link
Contributor

@ausbin ausbin commented Sep 26, 2023 •
edited

This error gets propagated to autograders, so a more friendly error message is useful

The current behavior is this, which confuses students:

java.lang.NullPointerException: Cannot read field "circuits" because "circuitFile" is null
	at com.ra4king.circuitsim.gui.CircuitSim.lambda$loadCircuits$57(CircuitSim.java:1477)
	at java.base/java.lang.Thread.run(Thread.java:833)

@ausbin
Throw a slightly more friendly message when a student opens an empty …
d261640 
…file

This error gets propagated to autograders, so a more friendly error message is useful
ausbin added a commit to gt-cs2110/CircuitSim that referenced this pull request Sep 26, 2023
@ausbin
Throw a friendly error message for empty files
e3f108a 
Our counterpart of ra4king#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ausbin