Call floating wires "z" instead of "x" #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blue wires are high impedance, and the standard name for that state is z, not x. Also remove the spots in the documentation where floating is called "uninitialized."
ausbin
added a commit
to gt-cs2110/CircuitSim
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blue wires are high impedance, and the standard name for that state is z, not x (e.g., in Verilog), so make CircuitSim display "z" instead of "x". Also remove the spots in the documentation where floating is called "uninitialized."
To me at least, this screenshot justifies this change:
Jokes aside, I want to use CircuitSim in lecture, and I don't want to explain that "x" in CircuitSim means "z," but in a K-map, "x" means don't care. I'm going to cherry-pick this directly into the 2110 fork, but I wanted to send this upstream to avoid us diverging too much.