test that shows getRowsUpdated returns 0 in upsert
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian <sebastian.alfers@gmail.com>
sebastian-alfers
force-pushed
the
upsert-wrong-getRowsUpdated
branch
from
fc889a1
to
22af6ea
Compare
|
I tried to fix it, but did not really come to a point beside writing a reproducer as a test - which is why I created this draft pr instead of making an issue. Should I do the latter as well? |
sebastian-alfers
changed the title
getRowsUpdated returns 0 in upsert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a fix, but a test that shows that
getRowsUpdateddoes not return1for an inserted row in an upsert query.An upsert is basically
update ... if @@ROWCOUNT = 0 insert ...