Don't supply deprecated binary argument

Closes #110
r-lib · Jun 18, 2021 · 570e55c · 570e55c
1 parent 22f6ce0
commit 570e55c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: vdiffr
 Title: Visual Regression Testing and Graphical Diffing
-Version: 1.0.1
+Version: 1.0.2
 Authors@R: c(
     person("Lionel", "Henry", , "lionel@rstudio.com", c("cre", "aut")),
     person("Thomas Lin", "Pedersen", , "thomas.pedersen@rstudio.com", 

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# vdiffr 1.0.1
+# vdiffr 1.0.2
 
 * testthat no longer auto-deletes snapshot files that were not
   generated because of an unexpected error or a `skip()`

diff --git a/R/expect-doppelganger.R b/R/expect-doppelganger.R
@@ -128,8 +128,8 @@ expect_doppelganger <- function(title,
     testthat::expect_snapshot_file(
       testcase,
       name = file,
-      binary = FALSE,
-      cran = cran
+      cran = cran,
+      compare = testthat::compare_file_text
     ),
     expectation_failure = function(cnd) {
       if (is_snapshot_stale(title, testcase)) {

diff --git a/tests/testthat/test-expect-doppelganger.R b/tests/testthat/test-expect-doppelganger.R
@@ -47,7 +47,7 @@ test_that("stale snapshots are skipped", {
     return()
   }
 
-  cnd <- catch_cnd(expect_doppelganger(title, plot))
+  cnd <- catch_cnd(expect_doppelganger(title, plot), "skip")
   expect_s3_class(cnd, "skip")
   file.remove(new_path)
 })