Adjust expand_range() so zero range scales respect mul and add #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jul 25, 2018
R/bounds.r
Outdated
| @@ -228,7 +228,7 @@ expand_range <- function(range, mul = 0, add = 0, zero_width = 1) { | |||
| if (is.null(range)) return() | |||
|
|
|||
| if (zero_range(range)) { | |||
There was a problem hiding this comment.
Maybe extract out width to be something like:
width <- if (zero_range(range)) zero_width else diff(range)
|
Yes, needs a news bullet (can point to the ggplot2 issue) I'd add a test just to make sure that mult and add affect |
hadley
approved these changes
Jul 25, 2018
|
(and please double check that it fixes the motivating problem) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed the most logical and minimal fix but if you have a different idea, let me know. Previously in expand_range(),
zero_widthwas divided in half and added or subtracted on either side of the axis tick, resulting (from defaults) in a range of 1 (so when the original issue poster calledgeom_boxplot(width=0)there was no padding). Now instead,zero_widthfunctions as ourdiff(range)and the equation matches that of non-zero ranges, respectingmulandadd.This fixes (the scales side of) the original issue (respecting
mulandaddparameters) but single ticket facets specifying a boxplotwidth≥ than this range will still look tight. Looking into this further I found some weird bugs happening with thewidthargument togeom_boxplotandgeom_violin. Will open a separate issue wherever appropriate once I have a better grasp on what's going on.Fixes tidyverse/ggplot2#2281.
Does this deserve a news bullet for scales? What sorts of downstream tests should I run? Would those belong on this PR?