Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libuv for <10.7 #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix libuv for <10.7 #401

wants to merge 1 commit into from

Conversation

barracuda156
Copy link

The patch fixes the build on older MacOS and is based on Macports one: https://github.com/macports/macports-ports/blob/master/devel/libuv/files/patch-libuv-legacy.diff

@barracuda156
Copy link
Author

Ubuntu check failure looks unrelated:

── R CMD check results ────────────────────────────────────── fs 1.5.2.9000 ────
Duration: 1m 5.6s

❯ checking compiled code ... WARNING
  File ‘fs/libs/fs.so’:
    Found ‘__sprintf_chk’, possibly from ‘sprintf’ (C)
      Object: ‘file.o’
  
  Compiled code should not call entry points which might terminate R nor
  write to stdout/stderr instead of to the console, nor use Fortran I/O
  nor system RNGs nor [v]sprintf.
  
  See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.

❯ checking for GNU extensions in Makefiles ... NOTE
  GNU make is a SystemRequirements.

0 errors ✔ | 1 warning ✖ | 1 note ✖
Error: Error: R CMD check found WARNINGs
Execution halted
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant