Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mac M1 support #365

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed Mac M1 support #365

wants to merge 6 commits into from

Conversation

yoshimoto
Copy link

Fixed a issue #348 by importing the latest config.sub from
https://git.savannah.gnu.org/cgit/config.git/plain/config.sub.

@colinbrislawn
Copy link

Looks like this built ok...

Is this ready to merge?

@cheungxi
Copy link

cheungxi commented Mar 8, 2022

This pr not updated config.guess. It will fail when build for loongarch64 CPU. @yoshimoto
How to pr your pr, haha.

@yoshimoto
Copy link
Author

@cheungxi Thank you. I've updated both of config.guess and config.sub.

However, the check on ubuntu-18.04 (oldrel-4) seems to have failed. Is this an another issue or not?

@cheungxi
Copy link

why no people review this pr ?

@colinbrislawn
Copy link

Looks like there's one error in one build:

* creating vignettes ... ERROR
Error: Error: processing vignette 'function-comparisons.Rmd' failed with diagnostics:
could not find function "pandoc_math_engines"
Execution halted

I'm not sure what would cause that error...

@yoshimoto
Copy link
Author

I re-ran the check and all tests have passed now.

For your information, I ran the check three times via same code, and got three different results:
1st: failed with https://github.com/r-lib/fs/runs/5473509786?check_suite_focus=true
2nd: failed with https://github.com/r-lib/fs/runs/5731473279?check_suite_focus=true
3rd: no error
I believe both 2 errors were false alarms and should be ignored here.

@cheungxi
Copy link

cheungxi commented Nov 4, 2022

Can merge to master ? @gaborcsardi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants