Revisions from February 2020 development review #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arni-magnusson
added
the
documentation
12 tasks
warnes
requested changes
Mar 29, 2020
man/bubbleplot.Rd
Outdated
| \item{std}{whether to standardize | ||
| \code{z = abs(z) / mean(abs(z))}.} | ||
| \item{pow}{a power coefficient for the bubble sizes. The | ||
| \code{pow = 0.5} (square root) is a good default, where a \code{z} |
There was a problem hiding this comment.
The documentation for std and pow are probably a bit much for the parameter descriptions. Perhaps the details of the calculation would probably be better put into a \details section
There was a problem hiding this comment.
Great idea. Done: fcc94df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubbleplot looks for
xyzcolumns in data frame.Improve wording in documentation, based on Greg's comments on February 2020 commits.