base: use a symlink for which instead of hard-coded path #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haampie
changed the title
haampie
added a commit
to haampie/spack
that referenced
this pull request
Jan 10, 2024
R embeds an absolute path to the `which` executable in the sources for `Sys.which`. This gets ultimately stored as serialized byte code in some custom database format, which uses compression for entries. As a result, Spack cannot relocate `<prefix which>/bin/which` when installing from a build cache. The patch works around this by making R create a symlink to `which` in its own prefix, have the R sources call that, so that relocation works again. See r-devel/r-svn#151
|
Looks like CI for windows is broken due to timeouts when installing miktex
|
alalazo
pushed a commit
to spack/spack
that referenced
this pull request
Jan 16, 2024
R embeds an absolute path to the `which` executable in the sources for `Sys.which`. This gets ultimately stored as serialized byte code in some custom database format, which uses compression for entries. As a result, Spack cannot relocate `<prefix which>/bin/which` when installing from a build cache. The patch works around this by making R create a symlink to `which` in its own prefix, have the R sources call that, so that relocation works again. See r-devel/r-svn#151
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 25, 2024
R embeds an absolute path to the `which` executable in the sources for `Sys.which`. This gets ultimately stored as serialized byte code in some custom database format, which uses compression for entries. As a result, Spack cannot relocate `<prefix which>/bin/which` when installing from a build cache. The patch works around this by making R create a symlink to `which` in its own prefix, have the R sources call that, so that relocation works again. See r-devel/r-svn#151
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
R embeds an absolute path to the `which` executable in the sources for `Sys.which`. This gets ultimately stored as serialized byte code in some custom database format, which uses compression for entries. As a result, Spack cannot relocate `<prefix which>/bin/which` when installing from a build cache. The patch works around this by making R create a symlink to `which` in its own prefix, have the R sources call that, so that relocation works again. See r-devel/r-svn#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R hard-codes the path to the
whichexecutable inside bytecode, which isstored in a compressed format.
This makes it very hard to relocate R itself at a later stage, or update the
path to
whichif it ever moves on the system.This patch creates a symlink
rlib/R/library/base/R/which ->/path/to/bin/whichso it's easier to relocate R / which, as you can justmodify a symlink instead of dealing with
base.rdbandbase.rdxfiles.