Allow usage of rasterio instead of GDAL's python bindings for loading/saving of files #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to use rasterio rather than GDAL python bindings
tgrandje
changed the title
|
@tgrandje - Thanks! Rather than using the big try-except blocks, it would have been better to put the contents of said blocks into their own functions in order to make the logic of the try-except clearer. I'll accept this and make that change myself. |
r-barnes
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to use rasterio rather than GDAL's python bindings: GDAL's python bindings can be gruesome to install, especially on windows) ; rasterio includes it's own API and a GDAL distribution (whereas GDAL python package does not).
GDAL's python bindings (= GDAL python package, refered further to as 'gdal') and rasterio are not compatible; more can be found there. As gdal initializes the context at the first call of the module, I chose to test the presence of rasterio first.
(Sorry for the diff-file format; it will be difficult to read because I moved all exceptions messages at the start of LoadGDAL, instead of duplicating these in rasterio's and gdal's sections...)