Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make logging explicit and fix a function #62

Closed
wants to merge 1 commit into from

Conversation

sunayana
Copy link

  • makes RICHDEM_LOGGING flag explicit in CMakeLists.txt
  • fixes assert in FM_OCallaghan template function.

- makes RICHDEM_LOGGING flag explicit in CMakeLists.txt
- fixes assert in FM_OCallaghan template function.
@r-barnes
Copy link
Owner

The assertion doesn't look it needed fixing. I've incorporated the cmake change. I wasn't able to take the PR directly because of the blast radius on the whitespace.

@r-barnes r-barnes closed this May 15, 2024
@r-barnes
Copy link
Owner

My bad. I've fixed the assertion in FM_OCallaghan now - thanks!

@sunayana
Copy link
Author

Thanks @r-barnes. Also to let you know we used richdem in Cervest and created a Julia wrapper for your code, here is a link to the fork:
https://github.com/Cervest/richdem
and the Julia wrapper is here:
https://github.com/Cervest/richdem/tree/master/wrappers/RichDEM.jl

@r-barnes
Copy link
Owner

@sunayana - Cool! Would you be interested in trying to merge that all upstream? I can get you some collaborator access to the repo if that's helpful.

@sunayana
Copy link
Author

@r-barnes - Yes I would be happy to push the changes upstream if you would give me collaborator access to the repo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants